-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce grunt #97
Comments
+1 Have to wait for @sizzlemctwizzle to include you into the team or you can submit a PR. |
@solygen You've been added to the team. You can push your branch to this repo and submit a pull request when you're ready for us to review it. |
I did not get the dev environment running... i've started with node js a few weeks ago. So please someone be so kind and take a look at my changes. jshint will still fail at lib/muExpress.js
htmlmin will fail for views/userAdmin.html
Perhaps someone with deeper understandings could take a look at it. |
It probably won't pass on a mustache file as-is (and we shouldn't be minifying those anyways). If anything, templates should be preprocessed, not minified. Look into grunt-mustache-precompile for that. As for why it is failing, |
This would only work on the public folder. |
How about just reverting the html minify part and putting everything else on the road? Imho for the first step the most important part is to introduce a simple grunt infrastructure and guarantee code quality/standards by using the jshint task. |
HTML minify or preprocessed can always be added later. Still +1 on this. |
I don't always agree with these types of analyzers especially since the ES standards are evolving so we would need to keep right on the bleeding edge of every implementation of JavaScript and it's variants in every released browser... which is difficult to do. The analyzing in Ace is already dated in a few areas too but luckily it isn't in most peoples way. Leaning towards -1 due to possible licensing conflicts with their CLA. |
JavaScript & CSS minification has already implemented with express-minify. @Martii Are you still -1 👎 on this enhancement to implement JSHint with Grunt (CLA or styleguide conflicts)? |
Well based off of #406 issues I would have to give it a -1 just due to that... but there is always the possibility that user error came into play e.g. misconfigured... but the CLA is something that's not going to happen any time soon. We can revisit this if it becomes a necessity but closing... leave his branch on OpenUserJS.org though. See also: |
In case the team don't mind i would realize some simple tasks in a feature branch.
The text was updated successfully, but these errors were encountered: