Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce grunt #97

Closed
solygen opened this issue May 14, 2014 · 10 comments
Closed

introduce grunt #97

solygen opened this issue May 14, 2014 · 10 comments
Labels
feature Something we don't already have implemented to the best of knowledge but would like to see. wontfix Nope, nada, zip, zilch.

Comments

@solygen
Copy link

solygen commented May 14, 2014

  • concat/minify css files
  • include jshint check
  • minify html
  • ...

In case the team don't mind i would realize some simple tasks in a feature branch.

@jerone
Copy link
Contributor

jerone commented May 14, 2014

+1

Have to wait for @sizzlemctwizzle to include you into the team or you can submit a PR.

@sizzlemctwizzle
Copy link
Member

@solygen You've been added to the team. You can push your branch to this repo and submit a pull request when you're ready for us to review it.

@solygen
Copy link
Author

solygen commented May 15, 2014

I did not get the dev environment running... i've started with node js a few weeks ago. So please someone be so kind and take a look at my changes.

jshint will still fail at lib/muExpress.js

The '__proto__' property is deprecated.

htmlmin will fail for views/userAdmin.html

Parse Error: <option value="{{{val}}}" {{#selected}}selected="{{selected}}"{{/selected}}>

Perhaps someone with deeper understandings could take a look at it.

@cletusc
Copy link
Contributor

cletusc commented May 15, 2014

It probably won't pass on a mustache file as-is (and we shouldn't be minifying those anyways). If anything, templates should be preprocessed, not minified. Look into grunt-mustache-precompile for that.

As for why it is failing, {{#selected}} is within the attributes section of the option tag and {, #, and } are invalid characters for an attribute name.

@Martii Martii added Feature and removed enhancement labels Jun 1, 2014
@sizzlemctwizzle
Copy link
Member

This would only work on the public folder.

@solygen
Copy link
Author

solygen commented Jun 13, 2014

How about just reverting the html minify part and putting everything else on the road?

Imho for the first step the most important part is to introduce a simple grunt infrastructure and guarantee code quality/standards by using the jshint task.

@jerone
Copy link
Contributor

jerone commented Jun 13, 2014

How about just reverting the html minify part and putting everything else on the road?

HTML minify or preprocessed can always be added later.
Can you update the branch with the latest commits...

Still +1 on this.

@Martii
Copy link
Member

Martii commented Jun 13, 2014

guarantee code quality/standards

I don't always agree with these types of analyzers especially since the ES standards are evolving so we would need to keep right on the bleeding edge of every implementation of JavaScript and it's variants in every released browser... which is difficult to do. The analyzing in Ace is already dated in a few areas too but luckily it isn't in most peoples way.


Leaning towards -1 due to possible licensing conflicts with their CLA.

@jerone
Copy link
Contributor

jerone commented Nov 25, 2014

JavaScript & CSS minification has already implemented with express-minify.
HTML minification is still optional.

@Martii Are you still -1 👎 on this enhancement to implement JSHint with Grunt (CLA or styleguide conflicts)?

@Martii Martii added the mightfix Ehh maybe... convince us all... label Nov 25, 2014
@Martii
Copy link
Member

Martii commented Nov 25, 2014

Well based off of #406 issues I would have to give it a -1 just due to that... but there is always the possibility that user error came into play e.g. misconfigured... but the CLA is something that's not going to happen any time soon. We can revisit this if it becomes a necessity but closing... leave his branch on OpenUserJS.org though.

See also:

@Martii Martii closed this as completed Nov 25, 2014
@Martii Martii added wontfix Nope, nada, zip, zilch. and removed mightfix Ehh maybe... convince us all... labels Mar 27, 2015
@Martii Martii mentioned this issue Mar 27, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Something we don't already have implemented to the best of knowledge but would like to see. wontfix Nope, nada, zip, zilch.
Development

No branches or pull requests

5 participants