From fb60757538577ba3d599a5dea0a65d50b53be883 Mon Sep 17 00:00:00 2001 From: Lev Stipakov Date: Tue, 4 Apr 2023 18:23:58 +0300 Subject: [PATCH] msi: configure OpenVPN Service also on reinstall We configure openvpn service (set startup mode and run, if needed) only on installation or upgrade. This is achieved by running configuration custom action with "NOT Installed" condition. However the product may be reinstalled (even though we disable it in UI), for example when pushed via AD Group Policy or with command line msiexec /fomusv "OpenVPN-2.6.2-I001-amd64.msi" /L*V reinstall.log In this case OpenVPN service status is set to "disabled", since our configuration custom action won't be run. Fix by changing action condition to NOT REMOVE, which covers both install/upgrade and reinstall cases. Fixes https://github.com/OpenVPN/openvpn-build/issues/348 Change-Id: I92974dea4749c415e25ab0f804050e3e6d309ffc Signed-off-by: Lev Stipakov --- windows-msi/msi.wxs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/windows-msi/msi.wxs b/windows-msi/msi.wxs index 5e9a86b4..31416b6a 100644 --- a/windows-msi/msi.wxs +++ b/windows-msi/msi.wxs @@ -100,7 +100,7 @@ - NOT Installed + NOT REMOVE