Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config file is not reloaded on change #19

Closed
builderjer opened this issue Jun 25, 2023 · 2 comments · Fixed by #57
Closed

config file is not reloaded on change #19

builderjer opened this issue Jun 25, 2023 · 2 comments · Fixed by #57

Comments

@builderjer
Copy link
Member

While doing some TTS testing, I noticed that my audio.log would show that ~/.config/mycroft/mycroft.conf was changed and it was reloading the TTS engine, BUT it did not actually do that. Before the config was recognized, I had to restart the service
@builderjer
Copy link
Member Author

this is what is showing when it is changed

2023-06-25 08:37:19.972 - audio - ovos_config.config:_on_file_change:323 - INFO - /home/ovos/.config/mycroft/mycroft.conf changed on disk
2023-06-25 08:37:19.978 - audio - ovos_config.config:_on_file_change:324 - DEBUG - Calling 1 callbacks
2023-06-25 08:37:19.983 - audio - ovos_audio.service:_maybe_reload_tts:308 - INFO - (re)loading fallback TTS engine

But it does not actually change

@goldyfruit
Copy link
Member

goldyfruit commented Jul 2, 2023 •
edited
Loading

Same behaviour for me.

@JarbasAl JarbasAl mentioned this issue Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix/tts_reload OpenVoiceOS/ovos-audio
2 participants
@goldyfruit @builderjer