From 5312d53d17994074146c6654c9ecc4bb931c7f5f Mon Sep 17 00:00:00 2001 From: miro Date: Sat, 11 May 2024 05:32:41 +0100 Subject: [PATCH] fix/legacy_playlist_queue bug: queueing new tracks always replaced old playlist detected in end2end tests from https://github.com/OpenVoiceOS/ovos-audio/pull/64/ --- ovos_plugin_manager/templates/audio.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/ovos_plugin_manager/templates/audio.py b/ovos_plugin_manager/templates/audio.py index c8d1e398..9f012d04 100644 --- a/ovos_plugin_manager/templates/audio.py +++ b/ovos_plugin_manager/templates/audio.py @@ -242,12 +242,10 @@ def add_list(self, tracks): tracks = [tracks] elif not isinstance(tracks, list): raise ValueError - if tracks: + if tracks and not self._tracks: self.load_track(tracks[0]) self._idx = 0 - else: - LOG.error("called add_list without tracks!") - self._tracks = tracks + self._tracks += tracks def next(self): """Skip to next track in playlist.""" @@ -340,7 +338,7 @@ def load_track(self, uri): self._now_playing = uri LOG.debug(f"queuing for {self.__class__.__name__} playback: {uri}") self.bus.emit(Message("ovos.common_play.media.state", - {"state": MediaState.LOADED_MEDIA})) + {"state": MediaState.LOADING_MEDIA})) self.bus.emit(Message("ovos.common_play.track.state", { "state": TrackState.QUEUED_AUDIOSERVICE }))