Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constructor parameter for ERC20 Premint #73

Open
frangio opened this issue Dec 22, 2021 · 2 comments
Open

Use constructor parameter for ERC20 Premint #73

frangio opened this issue Dec 22, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@frangio
Copy link
Contributor

frangio commented Dec 22, 2021

Currently ownership and roles are assigned to msg.sender, which is a problem for factory contracts. We can have a toggle to use a constructor parameter instead.

@defido
Copy link

defido commented Feb 13, 2022

This would be a great addition, there's a lot of factory contracts that could help projects, but currently setting ownership with OZ is problematic.

@ericglau ericglau added the good first issue Good for newcomers label Jan 9, 2023
@ericglau
Copy link
Member

ericglau commented Jan 28, 2025

This was changed to use a constructor parameter for most cases. The only remaining scenario is the recipient of ERC20's Premint amount -- this could also use a constructor parameter to be consistent.

@ericglau ericglau changed the title Add a toggle to use msg.sender or constructor parameter for roles/ownership Use constructor parameter for ERC20 Premint Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants