Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

add warning about deploy deprecation #277

Closed
martriay opened this issue Nov 2, 2022 · 2 comments · Fixed by #276
Closed

add warning about deploy deprecation #277

martriay opened this issue Nov 2, 2022 · 2 comments · Fixed by #276
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@martriay
Copy link
Contributor

martriay commented Nov 2, 2022

@frangio suggested to add a warning to nile deploy about its upcoming deprecation, and that it will require an account soon.
once we fully replace the command with #276, calling the command this way should let the user know about the new flow

@martriay martriay added the documentation Improvements or additions to documentation label Nov 2, 2022
@martriay martriay moved this to 📋 Backlog in Cairo team Nov 2, 2022
@ericnordelo
Copy link
Member

ericnordelo commented Nov 3, 2022

I will add the warning in 276.

A note on that: 276 will not fully replace the command but will add extra support for deployments through accounts.

To fully replace the command, I think we need at least to support starknet-devnet 0.3.5 (with predeployed UDC), because, until that, users need to manually deploy at least UDC for deploying through accounts.

Btw, the predeployed UDC in starknet-devnet is at address 0x25fcb74260022bd8ed7e8d542408941826b53345e478b8303d6f31744838a36, different from the one in goerli and mainnet.

@ericnordelo ericnordelo linked a pull request Nov 3, 2022 that will close this issue
@martriay
Copy link
Contributor Author

martriay commented Nov 3, 2022

Related: 0xSpaceShard/starknet-devnet#326

@martriay martriay added this to the current milestone Nov 5, 2022
@martriay martriay moved this from 📋 Backlog to 👀 In review in Cairo team Nov 5, 2022
Repository owner moved this from 👀 In review to ✅ Resolved in Cairo team Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants