Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tokenURI field of ERC20WithMetadata from private to internal #1612

Closed
leonprou opened this issue Jan 17, 2019 · 2 comments
Closed

Change tokenURI field of ERC20WithMetadata from private to internal #1612

leonprou opened this issue Jan 17, 2019 · 2 comments
Labels
contracts Smart contract code. feature New contracts, functions, or helpers.
Milestone

Comments

@leonprou
Copy link

🧐 Motivation
I want to use ERC20WithMetadata contract, but I would like to introduce logic that changes the tokenURI field. For example that just the owner of the token can change the tokenURI.
We are building a token studio, and the issuer might be unsure about token metadata when he creates the token. Also some token metadata like addresses and etc might change. Not sure, but I think it doesn't break the EIP-1047.

📝 Details
Changing the tokenURI field to internal should solve this problem.

@nventuro
Copy link
Contributor

EIP721 explictly allows this (see the Rationale section, under 'Metadata Choices':

The URI MAY be mutable (i.e. it changes from time to time). We considered an NFT representing ownership of a house, in this case metadata about the house (image, occupants, etc.) can naturally change.

I think this is a fair point and wouldn't be against this addition.

@nventuro nventuro added feature New contracts, functions, or helpers. contracts Smart contract code. labels Jan 17, 2019
@nventuro nventuro added this to the v2.3 milestone Jan 17, 2019
@leonprou
Copy link
Author

@nventuro great, thanks for the quick response.

I guess it will take some time this will be released. So for now I copied the TokenMetadata contract and make the change myself. You can see it here.

Also I can make a PR to the repo if it helps.

@frangio frangio modified the milestones: v2.3, v2.2 Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Smart contract code. feature New contracts, functions, or helpers.
Projects
None yet
Development

No branches or pull requests

3 participants