You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#2027 made some functions, including _approve, internal. A comment indicated that doing this required that a commented-out require statement be restored, but this was not done.
This leads to some of the arguments of these internal functions not being properly validated, including allowing for _approve's holder to be the zero address. We should:
restore this require statement
evaluate which arguments of the other functions made internal in that PR should be validated
and backport the fix to v2.5
The text was updated successfully, but these errors were encountered:
#2027 made some functions, including
_approve
,internal
. A comment indicated that doing this required that a commented-outrequire
statement be restored, but this was not done.This leads to some of the arguments of these internal functions not being properly validated, including allowing for
_approve
'sholder
to be the zero address. We should:internal
in that PR should be validatedThe text was updated successfully, but these errors were encountered: