Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm package artifacts broken since migration to Hardhat #2519

Closed
frangio opened this issue Feb 10, 2021 · 1 comment
Closed

Fix npm package artifacts broken since migration to Hardhat #2519

frangio opened this issue Feb 10, 2021 · 1 comment

Comments

@frangio
Copy link
Contributor

frangio commented Feb 10, 2021

The npm package contains precompiled build artifacts for the contracts. These were generated by Buidler in artifacts and copied to the Truffle-expected location in build/contracts by the prepack.sh script.

# cross platform `mkdir -p`
node -e 'fs.mkdirSync("build/contracts", { recursive: true })'
cp artifacts/*.json build/contracts

This is broken since the migration to Hardhat which now creates a different directory structure in artifacts.

I'm considering we should just get rid of build/contracts from the npm package. Using those files doesn't really work consistently in Truffle. If we remove them there are many things that have to be adapted. Searching for "build/contracts" in the repo provides good pointers of where we should change something.

@frangio
Copy link
Contributor Author

frangio commented Feb 22, 2021

Fixed in #2503

@frangio frangio closed this as completed Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant