Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix timestamp used for protocol completion #16855

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Nov 15, 2024

Closes RQA-3596

Overview

It appears we've been using the createdAt timestamp instead of the completedAt timestamp for last run copy. Whoops.

Current Behavior

Screen.Recording.2024-11-15.at.12.24.41.PM.mov

Fixed Behavior

Screen.Recording.2024-11-15.at.1.34.50.PM.mov

Test Plan and Hands on Testing

  • See video

Changelog

  • Fixed ODD dashboard cards reflecting an incorrect timestamp.

Risk assessment

low

@mjhuff mjhuff requested review from sfoster1, TamarZanzouri, smb2268 and a team November 15, 2024 18:58
@mjhuff mjhuff requested a review from a team as a code owner November 15, 2024 18:58
@mjhuff mjhuff force-pushed the app_fix-timestamp-protocol-completion branch from 9e53c4b to e0047a5 Compare November 15, 2024 19:11
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hwhoops

Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mjhuff mjhuff force-pushed the app_fix-timestamp-protocol-completion branch from e0047a5 to 9e53c4b Compare November 15, 2024 21:30
@mjhuff
Copy link
Contributor Author

mjhuff commented Nov 18, 2024

While github takes it's time to process this branch's updates:

I thought something odd was going on with the ProtocolDashboard completedAt field not reflecting what we'd intuitively think it should, but turns out things were fine once I cleared the protocol run history and tried again.

That being said, timestamps aren't continually updated when viewing the ProtocolDashboard, so I've adjusted that.

@mjhuff mjhuff merged commit 57ea4ae into chore_release-8.2.0 Nov 18, 2024
30 checks passed
@mjhuff mjhuff deleted the app_fix-timestamp-protocol-completion branch November 18, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants