fix(app): fix post run tip detection after error recovery #16860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
requested review from
shlokamin
and removed request for
a team and
shlokamin
mjhuff
commented
Nov 15, 2024
| 'dropTip', | ||
| 'dropTipInPlace', | ||
| 'pickUpTip', | ||
| 'moveToAddressableAreaForDropTip', |
There was a problem hiding this comment.
This is annoying, but thankfully the app doesn't have to keep track of all these separate commands much longer thanks to #16859
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3589
Overview
It's insufficient to check if a run entered error recovery as the sole condition for whether or not to run the post-run drop tip wizard, because it's possible for a run to proceed through error recovery then encounter a terminal error. In these spots, we must show drop tip wizard.
To fix, determine whether the run just entered error recovery (or not). If it didn't, do the tip detection logic.
Screen.Recording.2024-11-15.at.2.53.55.PM.mov
Test Plan and Hands on Testing
Changelog
Risk assessment
low -- This util only touches two spots, and the blast radius is small.