-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove until-build attribute from idea-version tag in plugin.xml #200
Comments
In general I'm against this because from my experience, sometimes APIs change and break between IntellIJ version,, and I don't want to give the false impressions that the plugin automatically works with every new version because it might not. Things break and I want to try and make sure nothing bad happens to your code/project because of these incompatibilities. That's why I go to great lengths to test every version of the plugin when I update it to new versions of IntelliJ. This does mean updates take longer (since I'm doing this for free on my free time) but that's open source for you :) |
Hm, I tend to disagree. I understand, that you do this in your spare time. And I am truly grateful for all your efforts. I bet the community highly appreciates your efforts in doing thorough tests. But if this results in waiting months for using the plugin, then this sort of renders this plugin useless. And see, it is already am month regarding #204 People suggest workarounds by hacking the XML files in the jar directly. And after all, you cannot test everything. Things will break, they always do. It is just a matter of time. Why not give this to the community? If something breaks, one can create an issue or even a pull request with a fix. Problems get solved even faster and the plugin is always up to date. I bet the community will find issues you wouldn't ever dream of 😄 So, maybe it is still a valid request? |
@Jeansen I thought about this again in light of my delay on #204 and the fact I don't want to hinder people that work and rely on my plugin. I'm definitely willing to remove until-build, but only if we have tests for at least the basic functionality of the plugin. I haven't done this before but this seems like a good start: I'd be thrilled if anyone wants to get the ball rolling with even getting a single test to work |
I had yet another remind that APIs break. I'm closing this. |
Remove until-build altogether from the META-INF/plugin.xml.
http://www.jetbrains.org/intellij/sdk/docs/basics/getting_started/build_number_ranges.html?search=until-build
Currently gitflow4idea stops working on almost every new release because of this tag.
gitflow4idea should keep working 🙂
I suspect you have many more tickets that it doesn't work because of this tag then you would have if you just remove the "until-build".
If in the future someone opens a ticket that is indeed doesn't work, in that case it's a real issue.
The text was updated successfully, but these errors were encountered: