Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Your search returned no results remains after successful search in admin UI #17337

Closed
jbytes1027 opened this issue Jan 11, 2025 · 9 comments · Fixed by #17415
Closed

Your search returned no results remains after successful search in admin UI #17337

jbytes1027 opened this issue Jan 11, 2025 · 9 comments · Fixed by #17415
Assignees
Labels
Milestone

Comments

@jbytes1027
Copy link
Contributor

jbytes1027 commented Jan 11, 2025

Problem

The You search has returned no results. message persists when there are search results.

Screenshot 2025-01-11 at 14-31-05 TheBlog - Features

To Reproduce

  1. Search for a module that doesn't exist such that there are no search results.
  2. Clear the search with ctrl-a + backspace.
  3. Scroll to the bottom of the page

Solution

Hide message on the next search with results.

@hishamco
Copy link
Member

Let me have a look

@hishamco
Copy link
Member

I can't reproduce the issue 100% but I notice when I click the clear button the alert still there, I will submit a PR

@jbytes1027
Copy link
Contributor Author

I noticed that if you delete the search text one char at a time with backspace the message doesn't show. It's only when you do ctrl-a + backspace the messages remains.

@hishamco
Copy link
Member

Why do I need to hit these combinations?

@jbytes1027
Copy link
Contributor Author

Probably something to do with the fact that the deleting one character at a time refreshes the search results several times. E.g. the text asd has no results. as has some results... etc.

@hishamco
Copy link
Member

The above case should work

@jbytes1027
Copy link
Contributor Author

jbytes1027 commented Jan 11, 2025

Deleting one char at a time works as it should; the message doesn't remain.

@sebastienros
Copy link
Member

Simple fix: remove the auto-refresh and wait for form submission to refresh the results.

@sebastienros sebastienros added this to the 3.x milestone Jan 16, 2025
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants