Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Messaging Notifications #1047

Closed
micahalcorn opened this issue Dec 5, 2018 · 5 comments
Closed

Messaging Notifications #1047

micahalcorn opened this issue Dec 5, 2018 · 5 comments
Assignees
Labels
dapp enhancement New feature or request javascript messaging notifications P1 Large amount of significant user impact, a meaningful feature is broken ui/ux

Comments

@micahalcorn
Copy link
Member

micahalcorn commented Dec 5, 2018

Browser nNotifications are currently only triggered by offer-related events. The notifications server should also be aware of messaging-related events and push these to subscribing recipients.

@micahalcorn
Copy link
Member Author

micahalcorn commented Jan 10, 2019

The status quo:

  • Here the messaging server notifies the linking server of a new message (for mobile push notifications).
  • Here the notifications server listens for offer-related events (from the discovery listener).
  • Here the notifications server notifies the linking server of a new offer-related event (for mobile push notifications).

Perhaps the notifications server should be responsible for all posts to the linking server regardless of source. I'm not sure whether or not the linking server correctly handles those.

cc @Natasha08 & @tomlinton (in case the are tunneling restrictions that will need to evolve)

@micahalcorn
Copy link
Member Author

To Do (somewhat related): refine all of the copy for the actual message strings that are pushed.

@Natasha08 Natasha08 self-assigned this Jan 11, 2019
@micahalcorn micahalcorn added the P3 Users are not significantly affected, minor cosmetic issue label Apr 11, 2019
@micahalcorn micahalcorn added P1 Large amount of significant user impact, a meaningful feature is broken and removed P3 Users are not significantly affected, minor cosmetic issue labels Apr 26, 2019
@micahalcorn
Copy link
Member Author

Bumping this up to 🅿️1️⃣ in accordance with sprint planning and shifting the scope from browser push to email.

@micahalcorn micahalcorn added this to the 🇰🇷 4/24/19-5/7/19 milestone Apr 26, 2019
@wanderingstan
Copy link
Contributor

Gonna call this done with #2257

@micahalcorn
Copy link
Member Author

Done ✅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dapp enhancement New feature or request javascript messaging notifications P1 Large amount of significant user impact, a meaningful feature is broken ui/ux
Projects
None yet
Development

No branches or pull requests

3 participants