Documentation for MAX31855 sensor #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 6, 2018
|
About the image: It's based on this one right? If possible, I prefer self-made images because of copyright, but if you can't do that right now I would suggest at least providing attribution 😉 And while we're at it: that image is quite compressed and doesn't look too nice on big displays, could you use this one instead (also in 10x8 aspect ratio, which most images here use for consistency):
|
|
Ok, I took this one today, should I update it to this one? |
|
@sherbang Yes, perfect! |
|
Oh shit, sorry pressed wrong button 🤕 |
|
Branch updated. Thanks OttoWinter. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes
Pull request in esphomeyaml with YAML changes (if applicable): esphome/esphome#258
Pull request in esphomelib with C++ framework changes (if applicable): esphome/esphome-core#310
Checklist:
nextis for changes and new documentation that will go public with the next esphomelib release. Fixes, changes and adjustments for the current release should be created againstcurrent.