Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Dump native API Server config on boot #338

Merged
merged 4 commits into from
Dec 30, 2018
Merged

Dump native API Server config on boot #338

merged 4 commits into from
Dec 30, 2018

Conversation

voicevon
Copy link
Contributor

No description provided.

@@ -54,7 +54,7 @@ void APIServer::loop() {
}
}
void APIServer::dump_config() {

ESP_LOGI(TAG,"API Server:");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an info message, it's a config message.
Space missing after comma.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I will use ESP_LOGCONFIG().Thanks.

@OttoWinter OttoWinter changed the title Api server dump_config() should not be empty Dump native API Server config on boot Dec 30, 2018
@OttoWinter OttoWinter merged commit db3d520 into esphome:dev Dec 30, 2018
@voicevon voicevon deleted the api_server branch December 31, 2018 03:37
@esphome esphome locked and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants