Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments #50

Closed
Owez opened this issue Jan 5, 2023 · 3 comments · Fixed by #56 or #94
Closed

Comments #50

Owez opened this issue Jan 5, 2023 · 3 comments · Fixed by #56 or #94
Assignees
Labels
enhancement New feature or request

Comments

@Owez
Copy link
Owner

Owez commented Jan 5, 2023

🎉 Hey everyone from hackernews!

I'd like to add comment archiving to Yark in v1.3 because it's been suggested a few times, originally I didn't add it because I wanted to focus on the core archiver but now that it's stable comments would be a nice new feature as a time capsule and for OSINT stuff.

Not sure how the archive format will change to accomodate this; there will need to be a new "comments" bit on each video controlled by a new comment class, so this can be part of a new v4 of the archive format which will also change with #27

@Owez Owez added the enhancement New feature or request label Jan 5, 2023
@Owez Owez self-assigned this Jan 5, 2023
@Owez Owez added this to Yark 1.3 Jan 5, 2023
@Owez Owez moved this to In Progress in Yark 1.3 Jan 6, 2023
@Owez Owez assigned Owez and unassigned Owez Jan 6, 2023
@Owez Owez linked a pull request Jan 6, 2023 that will close this issue
@Owez
Copy link
Owner Author

Owez commented Jan 9, 2023

This PR will be really nice because the way it's been implemented so far makes it so user icons and their name history also can be archived. It makes me sort of want to migrate to sqlite eventually to generate reports of where users have commented and future features, as unfortunate as that is.

@Owez
Copy link
Owner Author

Owez commented Jan 11, 2023

Reopening because I'll do a seperate new PR for adding it to the viewer later in the month.

@Owez Owez reopened this Jan 11, 2023
@Owez Owez moved this from Done to In Progress in Yark 1.3 Jan 11, 2023
@Owez Owez mentioned this issue Jan 20, 2023
@Owez Owez linked a pull request Jan 20, 2023 that will close this issue
@Owez
Copy link
Owner Author

Owez commented Jan 23, 2023

Closed with #56 and #93

@Owez Owez closed this as completed Jan 23, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Yark 1.3 Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant