Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music loading failed #4

Closed
1 task done
coderkei opened this issue Feb 19, 2021 · 12 comments
Closed
1 task done

Music loading failed #4

coderkei opened this issue Feb 19, 2021 · 12 comments
Labels
bug Something isn't working

Comments

@coderkei
Copy link

coderkei commented Feb 19, 2021

Describe the bug/crash:

  • Upon installing the app and granting the storage permission, it says "Music loading failed". Pressing retry yields the same error. I have ensured the storage permission was granted. According to MediaStore I have approximately 1200 songs but I not sure if that is related.

Steps To Reproduce the bug/crash:

  1. Install app
  2. Press "Allow" for the storage permission prompt
  3. App says "Music Loading failed"
  4. Retry does nothing, nor does force closing and trying.

Phone Information:

Oppo Reno
ColorOS 7.1
Android 10

App version is 1.3.0 installed from the IzzyOnDroid F-Droid Repo.

Due Diligence:

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Feb 19, 2021

Interesting. Can you get a logcat of the app process so I can figure out where the error is? If I remember correctly, it should print a track trace to the console that I could use.

If that's not possible, Ill update Auxio to show the stack trace in the UI itself when the loading fails so that people don't have to get the stack trace manually.

@coderkei
Copy link
Author

coderkei commented Feb 19, 2021

I filtered the logcat by the app's pid so hopefully it has the information you need. I have attached it below.
log.txt

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Feb 19, 2021

Okay, seems like Auxio is trying to apply more than one genre to a song [Which I disallowed thinking that it was undefined behavior]. Is it possible that songs in your library have multiple genres in their metadata?

@coderkei
Copy link
Author

coderkei commented Feb 19, 2021

I don't think so, although using another Music Player (Vanilla Music in this instance), one of the Genres in the list is simply blank and I wonder if that's the cause. The majority of the songs under this genre are still regular albums however. I am also not sure if this is just Vanilla Music's way of saying the song has no genre.

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Feb 19, 2021

Possibly. Either way Im going to commit a change that removes the IllegalStateException that gets thrown when applying a genre to a song that already has one. It may result in a garbled genre but I think its better than a completely inoperable app. The change should be pushed to 1.3.1. I will also test a song with a blank genre metadata field to see if I get the same issue, if thats the case I can create a specialized fix for it.

@coderkei
Copy link
Author

I checked one of the songs with a blank Genre in a metadata tag editor and it seems to be a single space.

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Feb 19, 2021

Got it, Ill test a similar song and see what happens.

Edit: It seems to work just fine, even with multiple songs with that genre field. It may be something else.

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Feb 19, 2021

Try this debug APK, does the original issue still occur? [Rename it to app-debug.apk]

app-debug.zip

@coderkei
Copy link
Author

I am unable to install it, Package manager says "App not installed"

@OxygenCobalt
Copy link
Owner

Try this one, not sure what happened to the last one.

app-debug.zip

@coderkei
Copy link
Author

coderkei commented Feb 19, 2021

Seems to work fine now with that APK. Loads all the albums I have.

It did generate a heap dump when I changed the album listing order.

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Feb 19, 2021

Good, Ill push the changes and close this issue. As for when this fix will be in the mainline version, it will probably be at 1.3.1. Thanks for letting me know about this.

As for the heap dump, its just a leak with how the loading fragment navigates to the main fragment. I cant do anything about it and it seems to be a bug in the android source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants