New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images not loading on login page #2438

Open

ARWattam opened this issue Nov 16, 2022 · 1 comment

Assignees

Labels

Bug

ARWattam commented Nov 16, 2022

Bob says "looks like the link should be https://www.bv-brc.org/patric/images/bv-brc/bv-brc-logo-bgwhite.png"

This is what needs to be fixed. See Jira 501

ARWattam added the Bug label

ARWattam assigned mshukla1

dmachi commented Nov 16, 2022

This works from the main login screen, but fails when it shows the 'inline' login box (e.g. when you select a service while not logged in) because the image path is relative. It needs to be changed into a absolute path at https://github.com/BV-BRC/BV-BRC-Web/blob/6f9696ec4d2c692d88104b52ffd8abe1017178b8/public/js/p3/widget/templates/LoginForm.html#L3 and in the other locations where images are used in that template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment