Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseStyle for border-color #1551

Closed
gllrm-andres opened this issue Jan 11, 2019 · 1 comment
Closed

ParseStyle for border-color #1551

gllrm-andres opened this issue Jan 11, 2019 · 1 comment
Milestone

Comments

@gllrm-andres
Copy link

gllrm-andres commented Jan 11, 2019

In HTML Writer for tables, I trying set style border-color property, but the parseStyle() should be

case 'border-color':
 $styles['borderColor'] = trim($cValue, '#');
 break;

actually

case 'border-color':
 $styles['color'] = trim($cValue, '#');
 break;
@troosan
Copy link
Contributor

troosan commented Jan 17, 2019

Indeed, you are right, actually 'color' does not do anything, should have been bgColor to set the background color.
Ideally we should even be able to parse

border-color: red green blue pink;

to

$styles['borderTopColor'] = 'red';
$styles['borderRightColor'] = 'green';
$styles['borderBottomColor'] = 'blue';
$styles['borderLeftColor'] = 'pink';

@troosan troosan added this to the v0.17.0 milestone Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants