Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set PCLZip as the default zip class #197

Closed
ivanlanin opened this issue Apr 11, 2014 · 4 comments
Closed

Set PCLZip as the default zip class #197

ivanlanin opened this issue Apr 11, 2014 · 4 comments
Assignees
@ivanlanin
Labels
Consulting Request
Milestone
0.10.0

Comments

@ivanlanin
Copy link
Contributor

Since it's already available since #140, can we change our default zip class from PHP's ZipArchive to PCLZip? This will reduce our dependencies and will enable PHPWord for developers that can't use ZipArchive. We will be more "pure PHP library".
@Progi1984
Copy link
Member

Personnally, I agree. But we need to add documentation for changing this setting.

@ivanlanin
Copy link
Contributor Author

We just need to update this part :)

@Progi1984
Copy link
Member

Affirmative :)

@ivanlanin ivanlanin modified the milestones: 0.11.0, 1.0.0, Next Apr 13, 2014
@ivanlanin
Copy link
Contributor Author

I've done some testing and I found out that it's much slower when we use PCLZip. I drop this issue for now and leave ZipArchive as default.

@Progi1984 Progi1984 modified the milestones: 0.10.0, 1.0.0 Apr 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanlanin ivanlanin

Labels
Consulting Request
Milestone
0.10.0
Development

No branches or pull requests
2 participants
@ivanlanin @Progi1984