Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect variable naming conventions #2586

Closed
l4nos opened this issue Mar 19, 2024 · 1 comment · Fixed by #2655
Closed

Incorrect variable naming conventions #2586

l4nos opened this issue Mar 19, 2024 · 1 comment · Fixed by #2655
Assignees
@Progi1984
Labels
Bug Report
Milestone
1.3.0

Comments

@l4nos
Copy link

l4nos commented Mar 19, 2024

Not so much a bug, as it probablly still "Works".

But poor naming convention used, the headerIndex is reused for footers when it shoud be footerIndex.

TemplateProcessor class line numbers are below.

image
@Progi1984 Progi1984 self-assigned this Aug 8, 2024
@Progi1984 Progi1984 added this to the 2.0.0 milestone Aug 8, 2024
@Progi1984 Progi1984 mentioned this issue Aug 13, 2024
Merged
4 tasks
@Progi1984
Copy link
Member

@efpapado issue has been fixed by a maintainer. You can help him by sponsoring him through Github sponsors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Progi1984 Progi1984

Labels
Bug Report
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Template Processor : Fixed bad naming of variables PHPOffice/PHPWord
2 participants
@Progi1984 @l4nos