-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Support Node v19's default Keep-Alive #455
Comments
Also an issue with Node 20. |
Is there a resolution for this? |
Hello, |
Hello, Any other issue happening due to keep-alive (true or false) giving uncaught exceptions must be addressed in another issue if any. |
Describe the bug
After making enough requests, I get:
To Reproduce
Expected behavior
Error should not appear
Version
Additional context
The same socket gets reused in node v19. This means the same "close" handler gets added repeatedly.
My temporary solution is to force node to use a new socket for each request, but of course that's not ideal:
The text was updated successfully, but these errors were encountered: