From a6aa4dd85be0bc57b13cf882958ae0d8a5f95f45 Mon Sep 17 00:00:00 2001 From: Maximilian Roos Date: Mon, 20 Feb 2023 13:15:51 -0800 Subject: [PATCH 1/4] ci: Run non-core tests through `test-all.yaml` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As pointed out in https://github.com/PRQL/prql/pull/1860/files#r1112279486, we're currently running these tests twice — once because they're in the `test-all.yaml` workflow, which is called on `main` commits, and once because they're called on `main` themselves. This disables them being called by `main` commits. It's possible the existing mode is required to generate caches; let's try disabling and assess, though. --- .github/workflows/test-elixir.yaml | 3 --- .github/workflows/test-js.yaml | 3 --- .github/workflows/test-taskfile.yaml | 3 --- 3 files changed, 9 deletions(-) diff --git a/.github/workflows/test-elixir.yaml b/.github/workflows/test-elixir.yaml index 31d4c9caaea9..89b0b34097ac 100644 --- a/.github/workflows/test-elixir.yaml +++ b/.github/workflows/test-elixir.yaml @@ -1,9 +1,6 @@ name: test-elixir on: - push: - branches: - - main pull_request: paths: - "prql-elixir/**" diff --git a/.github/workflows/test-js.yaml b/.github/workflows/test-js.yaml index bb25f46cc634..dd2e4892b4fb 100644 --- a/.github/workflows/test-js.yaml +++ b/.github/workflows/test-js.yaml @@ -1,9 +1,6 @@ name: test-js on: - push: - branches: - - main pull_request: paths: - "prql-js/**" diff --git a/.github/workflows/test-taskfile.yaml b/.github/workflows/test-taskfile.yaml index cb6ab15be302..bb61730b1893 100644 --- a/.github/workflows/test-taskfile.yaml +++ b/.github/workflows/test-taskfile.yaml @@ -2,9 +2,6 @@ name: test-taskfile on: - push: - branches: - - main pull_request: types: [opened, reopened, synchronize, labeled] paths: From 00bd9c35adbba1473a45bb1e704027847eaea728 Mon Sep 17 00:00:00 2001 From: Maximilian Roos Date: Mon, 20 Feb 2023 13:23:55 -0800 Subject: [PATCH 2/4] --- .github/workflows/test-taskfile.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/test-taskfile.yaml b/.github/workflows/test-taskfile.yaml index bb61730b1893..5a9fe8c3449c 100644 --- a/.github/workflows/test-taskfile.yaml +++ b/.github/workflows/test-taskfile.yaml @@ -3,7 +3,6 @@ name: test-taskfile on: pull_request: - types: [opened, reopened, synchronize, labeled] paths: - Taskfile.yml - .github/workflows/test-taskfile.yaml From 89427fcc7289a5cd23574482896fc1278517fdde Mon Sep 17 00:00:00 2001 From: Maximilian Roos Date: Mon, 20 Feb 2023 13:26:07 -0800 Subject: [PATCH 3/4] --- .github/workflows/test-python.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/test-python.yaml b/.github/workflows/test-python.yaml index fd00d6c82242..212967b4928a 100644 --- a/.github/workflows/test-python.yaml +++ b/.github/workflows/test-python.yaml @@ -1,9 +1,6 @@ name: test-python on: - push: - branches: - - main pull_request: paths: - "prql-python/**" From 53fa2c781483fa1b24fc51770b6b675912f06d85 Mon Sep 17 00:00:00 2001 From: Maximilian Roos Date: Mon, 20 Feb 2023 13:26:20 -0800 Subject: [PATCH 4/4] --- .github/workflows/test-java.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/test-java.yaml b/.github/workflows/test-java.yaml index 7eac03959c0c..780c87f3da28 100644 --- a/.github/workflows/test-java.yaml +++ b/.github/workflows/test-java.yaml @@ -1,9 +1,6 @@ name: test-java on: - push: - branches: - - main pull_request: paths: - "prql-java/**"