Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad Loiter to alt function #13220

Closed
moreba1 opened this issue Oct 17, 2019 · 12 comments
Closed

Bad Loiter to alt function #13220

moreba1 opened this issue Oct 17, 2019 · 12 comments

Comments

@moreba1
Copy link
Contributor

moreba1 commented Oct 17, 2019

Describe the bug
loiter to alt : Do not give elevation change before reaching the loiter point.

Expected behavior

changing altitude during going to loiter point .

image

image

@moreba1 moreba1 changed the title Loiter to alt function Bad Loiter to alt function Oct 17, 2019
@julianoes
Copy link
Contributor

@dagar
Copy link
Member

dagar commented Oct 17, 2019

Where are you expecting it to intersect?

@moreba1
Copy link
Contributor Author

moreba1 commented Oct 17, 2019

@julianoes I dont know , in my test MIS_ALTMODE was 1 (default) . plane must change it's altitude considering max climb rate and max sink rate.

@julianoes
Copy link
Contributor

julianoes commented Oct 18, 2019

I'm not sure what the behaviour should be. What do you think @dagar and @RomanBapst?

@dagar
Copy link
Member

dagar commented Oct 18, 2019

This is the intended behavior (using loiter to attain an altitude), but variations are certainly possible if @moreba1 can elaborate.

@moreba1
Copy link
Contributor Author

moreba1 commented Oct 18, 2019

@dagar
In my proposed behavior there is improvement in power saving and time saving in both descent and climb. At the end of flight in descent no need to motor power for going to loiter waypoint . also In starting flight after takeoff or transition to fw it is better and safer that planes gain height.

@dagar
Copy link
Member

dagar commented Oct 18, 2019

That makes sense, I'm not sure that should be the behaviour within LOITER_TO_ALT (https://mavlink.io/en/messages/common.html#MAV_CMD_NAV_LOITER_TO_ALT).

We should already be able to make this the norm within a regular waypoint or loiter.

@moreba1
Copy link
Contributor Author

moreba1 commented Oct 19, 2019

The relevant code is in navigator/mission_block.cpp . In ardupilot code loiter_to_alt mode works like the proposed method.

image

@dagar
Copy link
Member

dagar commented Oct 19, 2019

LOITER_TO_ALT was specifically added for a landing sequence consisting of loitering down from the current altitude, then breaking out of the loiter on a tangent to begin your landing approach. Only descending via loiter is the point.

Questions

  1. How will your suggestion to change LOITER_TO_ALT impact that?
  2. Why do you need LOITER_TO_ALT to behave this way if it can already be achieved with a regular loiter or waypoint?

@moreba1
Copy link
Contributor Author

moreba1 commented Oct 20, 2019

Why do you need LOITER_TO_ALT to behave this way if it can already be achieved with a regular loiter or waypoint?

regular waypoint can not be used because it has not "heading wait" .
can we define a waypoint in mission before LOITER_TO_ALT in same position ?

@moreba1
Copy link
Contributor Author

moreba1 commented Oct 27, 2019

we can define initial altitude for loiter_to_alt points .

@stale
Copy link

stale bot commented Jan 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Jan 25, 2020
@moreba1 moreba1 closed this as completed Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants