Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port new airship vehicle type from v1.10 to master #14792

Closed
dan-leo opened this issue Apr 29, 2020 · 2 comments
Closed

Port new airship vehicle type from v1.10 to master #14792

dan-leo opened this issue Apr 29, 2020 · 2 comments

Comments

@dan-leo
Copy link
Contributor

dan-leo commented Apr 29, 2020

As mentioned in https://discuss.px4.io/t/new-vehicle-type-airship/16514, our team has created an airship vehicle type and the next step is to port it to master from v1.10 before it can be integrated.

It would be helpful if any caveats or challenges can be highlighted here. Once it is ported, the relevant documentation can also be updated!

@dagar
Copy link
Member

dagar commented Apr 29, 2020

I'm not sure about specific caveats or challenges in general, but depending on how far along you are I'd encourage you to open smaller incremental pull requests if you'd actually like detailed feedback.

As for maintaining support for a new vehicle type like this (that not many of us have access to) it will be quite helpful if you can add some basic automated testing (eg simple mission in gazebo).

@dan-leo
Copy link
Contributor Author

dan-leo commented May 7, 2020

I've ported the airship to master, and submitted a PR in sitl_gazebo and Firmware!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants