-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PX4 / QGC Sync on Tuning Sliders #9379
Comments
@LorenzMeier I don't remember discussing this issue with @thomasgubler but I can look into it this week. |
As discussed with @RomanBapst, we should first discuss which parameters need to be exposed on the Tuning Setup. Things we discussed:
I will also try tuning s500 with just MC_ROLL/PITCH_P and see if they are useful enough to be exposed as tuning sliders. |
When I compile master or stable v3.3 branch, I get these weird versions of tuning sliders. However, when I open the binary version, the sliders look normal. Can anyone figure out why this is so? Is there any special way of compiling to see the tuning sliders? @RomanBapst the fix for this issue is in my fork. Can you please confirm the values? |
Can you move any QGC problems to QGC Issues? |
often I´m using the iOS version of QGC which is not above v 3.2 and it looks for old tuning parameters like mc_roll_tc or mc_pitch_tc that are no more existing in current PX4 firmwares. |
Superseded by mavlink/qgroundcontrol#6438 |
The current tuning sliders in QGC link to parameters that we recently disabled. We need to map them to the new correct attitude parameters. @barzanisar I believe that @thomasgubler did discuss this with you last week. Have you filed issues for that or derived specs with @RomanBapst for it?
@barzanisar Please do this yourself as you already have the build setup for QGC. Here are the three tuning panels:
https://github.com/mavlink/qgroundcontrol/blob/16541062efa0acee5e128f61dcd23106a7afc1f6/src/AutoPilotPlugins/PX4/PX4TuningComponent.cc#L55-L78
Here is e.g. the one for Multicopters:
https://github.com/mavlink/qgroundcontrol/blob/16541062efa0acee5e128f61dcd23106a7afc1f6/src/AutoPilotPlugins/PX4/PX4TuningComponentCopter.qml
@RomanBapst Please take responsibility for making sure that all parameters and the wording make sense. @MaEtUgR @Stifael it would be great if you would contribute to this.
Also see: mavlink/qgroundcontrol#6438
The text was updated successfully, but these errors were encountered: