Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PX4 / QGC Sync on Tuning Sliders #9379

Closed
LorenzMeier opened this issue Apr 28, 2018 · 6 comments
Closed

PX4 / QGC Sync on Tuning Sliders #9379

LorenzMeier opened this issue Apr 28, 2018 · 6 comments
Assignees

Comments

@LorenzMeier
Copy link
Member

LorenzMeier commented Apr 28, 2018

The current tuning sliders in QGC link to parameters that we recently disabled. We need to map them to the new correct attitude parameters. @barzanisar I believe that @thomasgubler did discuss this with you last week. Have you filed issues for that or derived specs with @RomanBapst for it?

@barzanisar Please do this yourself as you already have the build setup for QGC. Here are the three tuning panels:
https://github.com/mavlink/qgroundcontrol/blob/16541062efa0acee5e128f61dcd23106a7afc1f6/src/AutoPilotPlugins/PX4/PX4TuningComponent.cc#L55-L78

Here is e.g. the one for Multicopters:
https://github.com/mavlink/qgroundcontrol/blob/16541062efa0acee5e128f61dcd23106a7afc1f6/src/AutoPilotPlugins/PX4/PX4TuningComponentCopter.qml

@RomanBapst Please take responsibility for making sure that all parameters and the wording make sense. @MaEtUgR @Stifael it would be great if you would contribute to this.

Also see: mavlink/qgroundcontrol#6438

@barzanisar
Copy link

@LorenzMeier I don't remember discussing this issue with @thomasgubler but I can look into it this week.

@barzanisar
Copy link

As discussed with @RomanBapst, we should first discuss which parameters need to be exposed on the Tuning Setup. Things we discussed:

  • Parameters for "Hover Throttle" and "Manual minimum throttle" exist and are correctly mapped.
  • Sliders for "Roll sensitivity" and "Pitch sensitivity" should either map to "MC_ROLL_P and MC_PITCH_P" or "MC_ROLLRATE_P and MC_PITCHRATE_P".
  • In my experience I have tuned MC_ROLLRATE_P more than MC_ROLL_P to achieve either a faster roll control response or reduce oscillations. So maybe we can consider mapping Rate parameters to the "roll/pitch sensitivity" sliders?

I will also try tuning s500 with just MC_ROLL/PITCH_P and see if they are useful enough to be exposed as tuning sliders.

@barzanisar
Copy link

@DonLakeFlyer @dogmaphobic
image

When I compile master or stable v3.3 branch, I get these weird versions of tuning sliders. However, when I open the binary version, the sliders look normal. Can anyone figure out why this is so? Is there any special way of compiling to see the tuning sliders?

@RomanBapst the fix for this issue is in my fork. Can you please confirm the values?
Also, I checked the tuning sliders for Plane and VTOL. They all exist. Do we need any changes there? Do we need to add any new parameters?

@DonLakeFlyer
Copy link
Contributor

Can you move any QGC problems to QGC Issues?

@taileron
Copy link
Contributor

often I´m using the iOS version of QGC which is not above v 3.2 and it looks for old tuning parameters like mc_roll_tc or mc_pitch_tc that are no more existing in current PX4 firmwares.
So the mapping should not be only handled by QCG otherwise newer PX4 with older QCG don´t match anymore. PX4 firmware should be able to translate tuning parameters into older QGC as well

@thomasgubler
Copy link
Contributor

Superseded by mavlink/qgroundcontrol#6438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants