Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] navigator initialization and mode change improvements #10611

Closed
wants to merge 1 commit into from

Conversation

dagar
Copy link
Member

@dagar dagar commented Sep 30, 2018

  • safely initialize every MissionBlock's _mission_item
  • allow position setpoint triplets with no valid position setpoint to be published
    • this ensures that the position controllers don't accidentally use an old position setpoint
  • move loiter and takeoff reposition handling into each class (full position setpoint triplet isn't needed)
  • delete dead code

Needs testing

Test

  • takeoff -> hold
  • reposition usage
  • switching modes

@dagar dagar requested a review from dakejahl September 30, 2018 18:52
@dakejahl
Copy link
Contributor

dakejahl commented Oct 5, 2018

SITL test's worked fine, real world test not so much....
https://review.px4.io/plot_app?log=f464696e-00bb-48a8-b82f-00e089d2fa98

  1. Issued a takeoff
  2. After successful takeoff then transition into loiter, changed to position
  3. Flew it forward a bit, no issues
  4. Issued return
  5. Quad begin to roll to reposition...kept rolling and then went inverted and smashed into the ground

This is flying todays master with pr-navigator-robust pulled on top of that.

@dakejahl
Copy link
Contributor

dakejahl commented Oct 9, 2018

FYI @dagar I flew this again but this time using an RC setup.... Definitely not safe to fly! haha

https://review.px4.io/plot_app?log=0d5f3f53-d3cc-4946-b125-cfeb4881ac8a

edit: hardfaults as it starts to roll to move towards home...

selection_001

Sanity check.... SITL works fines, no local changes in navigator

@dagar dagar force-pushed the pr-navigator_robust branch 2 times, most recently from 4eceac1 to 1a56a3b Compare October 16, 2018 22:30
@dagar dagar force-pushed the pr-navigator_robust branch from 1a56a3b to c526683 Compare November 9, 2018 20:53
@dagar dagar added this to the Release v1.9.0 milestone Nov 9, 2018
@dagar dagar changed the title navigator initialization and mode change improvements [WIP] navigator initialization and mode change improvements Nov 9, 2018
@stale
Copy link

stale bot commented Jul 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Jul 24, 2019

Closing as stale.

@stale
Copy link

stale bot commented Oct 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Oct 23, 2019
Copy link
Contributor

@dakejahl dakejahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💩

@stale stale bot removed the stale label Oct 24, 2019
@stale
Copy link

stale bot commented Jan 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Jan 22, 2020
@dagar
Copy link
Member Author

dagar commented Jan 22, 2020

The majority of the changes here eventually ended up in master.

@dagar dagar closed this Jan 22, 2020
@LorenzMeier LorenzMeier deleted the pr-navigator_robust branch January 18, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants