mtd delete old 24xxxx_mtd driver and switch to NuttX AT24XX driver #11202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzMeier
requested changes
Jan 12, 2019
There was a problem hiding this comment.
The reason for this driver is that it is writing in short bursts and yields the bus in-between. The upstream driver was blocking the I2C driver for the full write, which is deadly if any other I2C device is on the same bus.
It can literally block the bus for seconds.
We don't have bandwidth right now for the full required QA for this right now and its unclear if the changes would be accepted upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If possible we should use the AT24XX driver from NuttX directly rather than carrying our own modified version in mtd.
Assuming there's no obvious reason we shouldn't do this the next step is to test it on a crazyflie.