[WIP] boards name and number external SPI consistently #11336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
force-pushed
the
pr-ext_spi_consistency
branch
4 times, most recently
from
cbfeefa to
b582f08
Compare
davids5
reviewed
Jan 29, 2019
| @@ -244,17 +243,17 @@ __BEGIN_DECLS | |||
| #define PX4_SENSOR_BUS_FIRST_CS PX4_SPIDEV_ACCEL_MAG | |||
| #define PX4_SENSOR_BUS_LAST_CS PX4_SPIDEV_GYRO | |||
|
|
|||
| #define PX4_SPIDEV_EXTERNAL1 PX4_MK_SPI_SEL(PX4_SPI_BUS_EXTERNAL,0) | |||
| #define PX4_SPIDEV_EXTERNAL2 PX4_MK_SPI_SEL(PX4_SPI_BUS_EXTERNAL,1) | |||
| #define PX4_SPIDEV_EXTERNAL1_1 PX4_MK_SPI_SEL(PX4_SPI_BUS_EXTERNAL1,0) | |||
| #ifdef PX4_SPI_BUS_EXT | ||
| #define px4_spi_bus_external(bus) (bus == PX4_SPI_BUS_EXT) | ||
| #ifdef PX4_SPI_BUS_EXTERNAL1 | ||
| #define px4_spi_bus_external(bus) (bus == PX4_SPI_BUS_EXTERNAL1) |
There was a problem hiding this comment.
Should this be a complex with all the externals?
|
|
||
| if (g_dev == nullptr) { | ||
| goto fail; | ||
| } | ||
|
|
||
| if (OK != g_dev->init()) { | ||
|
|
||
| #ifdef PX4_SPIDEV_EXTERNAL1_2 |
There was a problem hiding this comment.
Is this the same functionality as it was?
dagar
changed the title
dagar
force-pushed
the
pr-ext_spi_consistency
branch
from
b582f08 to
fa54cbc
Compare
|
@davids5 what's up with this? |
|
@julianoes - it was @dagar work and has rotted. If if cleans it up and resolve the open, we can review it again. I would make the CS as external in the ID - i.e PX4_MK_SPI_EXT_SEL - then they are self describing. |
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the mess of different external SPI bus naming and numbering across boards.
Master
PR
Gradually working towards a simple unified mechanism for handling optional external peripherals without pushing the burden into every single driver and board.