Fix Snapdragon linking #11968
Merged
Fix Snapdragon linking #11968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sih (simulation in hardware) was compiled for Snapdragon, we got the linking problem below. I'm not sure why, supposedly the symbol `double sin(double)` is missing. undefined PLT symbol _LSin (705) /libpx4.so (symbol.c:303)
It looks like the atomic builtins are not available using QuRT and the Hexagon toolchain, so our best bet is to use `volatile` for the atomics.
dagar
approved these changes
May 6, 2019
There was a problem hiding this comment.
Unfortunate, but I don't have a better solution.
Thanks @julianoes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two linking issues on Snapdragon. For more infos check out the commit messages.
The fix for the missing atomic builtin was fairly obvious, for the
_LSinsymbol I had to bisect and then removesihfrom the Snappy build.Fixes #11945.