Update jMAVsim submodule and use SDK port in HITL #11990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dagar @LorenzMeier this should go into 1.9. |
bkueng
previously approved these changes
May 9, 2019
LorenzMeier
previously approved these changes
May 9, 2019
|
Let's get this merged as soon as it passes. |
This fixes cross-talk between the QGC and SDK UDP ports for HITL.
We forgot to add the option -s for jmavsim_run.sh which starts jMAVSim with the UDP port connecting to the SDK (port 14540).
julianoes
force-pushed
the
pr-jmavsim-sdk-port
branch
from
35009a2 to
b85f964
Compare
|
Submodule updated to master and branch rebased, ready to be merged. |
TSC21
approved these changes
May 9, 2019
dagar
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two small fixes for jMAVSim HITL, for more detail check the commit messages.
Tested: