Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vehicle_control_mode needs to be updated when offboard_control_mode is changed #12002

Merged
merged 1 commit into from
May 11, 2019

Conversation

okalachev
Copy link
Contributor

@okalachev okalachev commented May 11, 2019

For dynamic flights in OFFBOARD mode it's necessary to switch between position/velocity/attitude/rates submodes fast.

For now, changes is offboard_control_mode topic does not trigger Commander to update the status, so the vehicle_control_mode doesn't get updated, causing delays (0.1–0.2 s) for publishing appropriate setpoints.

Like in this log, where automatic flip is performed (notice the delay between offboard_control_mode and vehicle_control_mode updates):

nofix

https://logs.px4.io/plot_app?log=fd5ad882-c4fb-49cc-9713-9201a6ee1379

This fix makes updates simultaneous:

fix

https://logs.px4.io/plot_app?log=8c115337-4469-4de3-8490-33d619d66d21

These logs are from SITL, but we experienced the same on real hardware. In v1.8.2 it was making automatic flips impossible, without ugly hacks to switch to position control earlier to compensate the possible delay.

@dagar

@dagar dagar merged commit 77097b6 into PX4:master May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants