Fix bug Auto Land #12032
Merged
Fix bug Auto Land #12032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dagar @RomanBapst @Stifael - can we get this in? |
|
Yep, the reset didn't make much sense |
|
Backported to v1.9. 413acc5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with Auto Land, I realized the position lock was reset at every iteration thus not actually locking the position when the current latitude and longitude aren't valid.
EDIT: the other weird thing in auto land is this line https://github.com/PX4/Firmware/blob/master/src/lib/FlightTasks/tasks/Auto/FlightTaskAuto.cpp#L189
it sets
_triplet_targetz to thereference_altitudesince the triplet altitude is 0Test data / coverage
SITL logs
before PR
after PR