Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tunes: make sure a custom tune gets played #12063

Merged
merged 1 commit into from
May 25, 2019
Merged

fix tunes: make sure a custom tune gets played #12063

merged 1 commit into from
May 25, 2019

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented May 24, 2019

fixes custom commands, like: tune_control play -m MFT200CDEFGAB

fixes #12059

@bkueng
fix tunes: make sure a custom tune gets played
194aba0 
fixes custom commands, like: tune_control play -m MFT200CDEFGAB
@bkueng bkueng requested a review from potaito May 24, 2019 07:56
@bkueng bkueng mentioned this pull request May 24, 2019
Closed
potaito
potaito approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@potaito potaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks. I don't know how that bug snuck in.

@dagar
Copy link
Member

dagar commented May 24, 2019

@mcsauder FYI

@dagar dagar added the bug label May 24, 2019
@mcsauder
Copy link
Contributor

Works awesome! Tested on pixracer and pixhawk 4. Thanks @bkueng!

@bys1123
Copy link
Contributor

bys1123 commented May 25, 2019

Tested Nokia tone, works Awesome!

tune_control play -m MFT186MLL8O4EDL4O3F#MNG#MLL8O4C#O3BL4DMNEMLL8BAL4C#EA2

@LorenzMeier LorenzMeier merged commit 8002667 into master May 25, 2019
@LorenzMeier LorenzMeier deleted the fix_custom_tune branch May 25, 2019 15:58
@weekly-digest weekly-digest bot mentioned this pull request May 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potaito potaito potaito approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'tune_control play -m "XXX"' is not working
6 participants
@bkueng @dagar @mcsauder @bys1123 @potaito @LorenzMeier