introduce uORB::PublicationQueued and transition most orb_advertise_queue usage #12411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
force-pushed
the
pr-uORB_PublicationQueued
branch
from
e6bb60c to
fedf42e
Compare
dagar
force-pushed
the
pr-uORB_PublicationQueued
branch
from
fedf42e to
1750270
Compare
|
@mcsauder interested in this one? |
|
@dagar , I'll get it reviewed and test it when I get back from travels around Aug 1. |
julianoes
reviewed
Jul 31, 2019
|
This PR flies great, flight tested on pixhawk 4 mini, 250sized quad: https://review.px4.io/plot_app?log=114ba234-cbc6-4cc3-afd9-a9cf5c3393b2 |
mcsauder
previously approved these changes
Aug 2, 2019
There was a problem hiding this comment.
I can't spot anything beyond what @julianoes has commented on. This looks good to me.
@dagar, if you want to merge/rebase upstream I am happy to fly it again.
dagar
force-pushed
the
pr-uORB_PublicationQueued
branch
2 times, most recently
from
ba9e358 to
b84f1e3
Compare
dagar
force-pushed
the
pr-uORB_PublicationQueued
branch
from
b84f1e3 to
641d0bf
Compare
dagar
force-pushed
the
pr-uORB_PublicationQueued
branch
from
641d0bf to
9005cf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.