Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigator: fix save mission state. #12468

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

ToppingXu
Copy link
Contributor

@ToppingXu ToppingXu commented Jul 12, 2019

fix save_mission_state() function

Fixes #12460

@dagar
Copy link
Member

dagar commented Jul 14, 2019

Looks right. What testing have you done?

@dagar dagar self-requested a review July 14, 2019 17:05
@dagar dagar added the bug label Jul 14, 2019
@dagar dagar requested a review from julianoes July 14, 2019 17:05
Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ToppingXu thank you! I think that looks correct. How did you find this?

@ToppingXu
Copy link
Contributor Author

@julianoes I found that by chance, as I was doing some work on mission.

@julianoes
Copy link
Contributor

@ToppingXu ok thanks. And the change is tested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mission_state won't change after call save_mission_state
3 participants