Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mc_pos_control: takeoff fix implicit switch fallthrough #12825

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Aug 28, 2019

image

These can change to [[fallthrough]] with c++17.

@dagar dagar requested a review from julianoes August 28, 2019 13:14
@dagar
Copy link
Member Author

dagar commented Aug 28, 2019

Nevermind, clang doesn't like it.

@dagar dagar force-pushed the pr-mc_pos_control_takeoff_fallthrough branch from 4e82d58 to 9b716d1 Compare August 28, 2019 13:24
@dagar dagar requested a review from MaEtUgR August 28, 2019 13:25
@dagar
Copy link
Member Author

dagar commented Aug 28, 2019

Added -Wno-implicit-fallthrough for now.

@dagar
Copy link
Member Author

dagar commented Aug 28, 2019

image

@dagar
Copy link
Member Author

dagar commented Aug 28, 2019

Duplicate of #12820.

@dagar dagar force-pushed the pr-mc_pos_control_takeoff_fallthrough branch from 9b716d1 to ee6633f Compare August 28, 2019 13:57
@julianoes
Copy link
Contributor

Consider #12827.

@dagar dagar force-pushed the pr-mc_pos_control_takeoff_fallthrough branch 2 times, most recently from e02e532 to 8381056 Compare August 28, 2019 17:41
@dagar dagar force-pushed the pr-mc_pos_control_takeoff_fallthrough branch from 8381056 to b29f5c7 Compare August 28, 2019 18:42
@dagar
Copy link
Member Author

dagar commented Aug 28, 2019

We can merge this in addition to the other PRs.

@dagar dagar merged commit aebf244 into master Aug 28, 2019
@dagar dagar deleted the pr-mc_pos_control_takeoff_fallthrough branch August 28, 2019 22:16
@MaEtUgR MaEtUgR mentioned this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants