-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable pmw3901 flow if (new) parameter SENS_EN_PMW_FLOW is true #12848
enable pmw3901 flow if (new) parameter SENS_EN_PMW_FLOW is true #12848
Conversation
Another thing, On AV/ax-1 I didn't add the code, because there is strange 'if' that if there is no flow there is adis16497. Who can address what to do there? I don't know the reason for current implementation |
How about |
7fa2042
to
ce8332e
Compare
@dagar done. |
@BazookaJoe1900 No, that's not ok - please add the newlines. |
Ok, I will fix that later. |
ce8332e
to
bc73e7c
Compare
For av-x check the parameter, but only to start the ADIS16977 if the PMW3901 is disabled. |
3ee3ca9
to
45af979
Compare
Describe problem solved by the proposed pull request
the startup scripts try to start the pmw3901 flow on some boards by default. even if the drone doesn't has one connected.
that cause false errors on startup script for drones that doesn't has the sensors (most of the configurations)
Describe your preferred solution
New SENS_EN_PMW_FLOW parameter that allows to define if the sensor should be or not on the system.
Describe possible alternatives
With this parameter, starting the flow can moved to common rc.sensors file. curently its only on boards that compile the pmw3901.
In that case, boards that don't have the driver compiled will show "Parameter SENS_EN_PMW_FLOW not found" (that is being delt on #12832)
does that prefered?