Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added circuit_breaker_enabled_by_val() #13000

Merged

Conversation

BazookaJoe1900
Copy link
Member

@BazookaJoe1900 BazookaJoe1900 commented Sep 20, 2019

added and using circuit_breaker_enabled_by_val() where possible instead of circuit_breaker_enabled() which search for cbrk parameters by name, which is extensive process.

the circuit_breaker_enabled_by_val() use the param value, which get by use the c++ wrapper

Describe problem solved by the proposed pull request
described on: 'extensive on every parameter change #12992'

added and using circuit_breaker_enabled_by_val() where possible instead of circuit_breaker_enabled() which search for cbrk parameters by name, which is extensive process.
@BazookaJoe1900
Copy link
Member Author

there are few more calles to circuit_breaker_enabled() (by name) on some modules:
on SafetyButton, ToneAlarm - it isn't a periodic so I kept that.
on PX4IO, there isn't a use of the c++ parameter wrapper, this is a TODO: to add it there

Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, thanks.

@dagar
Copy link
Member

dagar commented Sep 22, 2019

@TSC21 the "Catkin build on ROS workspace" build on Jenkins has started failing regularly, can you take a look?

@dagar dagar merged commit fb3a91c into PX4:master Sep 22, 2019
@TSC21
Copy link
Member

TSC21 commented Sep 22, 2019

It's not clear what exactly is failing the test - if it is the node that doesn't start or if the node is not publishing any data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants