Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add param to choose vision observation noise source #13150

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

kamilritz
Copy link
Contributor

Until now the vision observation noise is set from the incoming vision covariance data lower bounded by the default noise parameters. This PR adds a parameter EKF2_EV_NOISE_EN that enforces the vision observation noise to be set from default parameters directly. This is specially helpful for tuning the fusion of vision data in the EKF or in cases where the vision sensor is sending unusable covariances.
The EKF2_EV_NOISE_EN parameter's default value is chosen such that the behavior is still the same, if the parameter is untouched.

@mhkabir

dagar
dagar previously approved these changes Oct 14, 2019
src/modules/ekf2/ekf2_params.c Outdated Show resolved Hide resolved
mhkabir
mhkabir previously approved these changes Oct 15, 2019
Copy link
Member

@TSC21 TSC21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TSC21 TSC21 added this to the Release v1.10.0 milestone Oct 15, 2019
@TSC21 TSC21 merged commit a4e035d into PX4:master Oct 15, 2019
@TSC21
Copy link
Member

TSC21 commented Oct 15, 2019

@kamilritz this needs to be brought to the ECL docs. FYI @hamishwillee

@kamilritz
Copy link
Contributor Author

Documentation: PX4/PX4-user_guide#587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants