-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add param to choose vision observation noise source #13150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
previously approved these changes
Oct 14, 2019
mhkabir
reviewed
Oct 14, 2019
mhkabir
requested changes
Oct 14, 2019
mhkabir
previously approved these changes
Oct 15, 2019
kamilritz
force-pushed
the
pr_ev_covariance_param
branch
from
October 15, 2019 11:17
d378c78
to
2f9bbff
Compare
TSC21
approved these changes
Oct 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@kamilritz this needs to be brought to the ECL docs. FYI @hamishwillee |
Documentation: PX4/PX4-user_guide#587 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the vision observation noise is set from the incoming vision covariance data lower bounded by the default noise parameters. This PR adds a parameter
EKF2_EV_NOISE_EN
that enforces the vision observation noise to be set from default parameters directly. This is specially helpful for tuning the fusion of vision data in the EKF or in cases where the vision sensor is sending unusable covariances.The
EKF2_EV_NOISE_EN
parameter's default value is chosen such that the behavior is still the same, if the parameter is untouched.@mhkabir