vscode debug minor improvements #13750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create new px4_sitl_replay config specifically for replay - ekf2 replay don't launch gazebo - add px4_sitl_test cmake variant - px4_sitl_test bring into sync with px4_sitl_default - vscode replace hard coded build path with cmake setting
dagar
force-pushed
the
pr-vscode_ekf2_replay
branch
from
7776016 to
c493ad0
Compare
|
An alternative would be using cmake options to properly set these things at configure time. |
|
@dagar I tested the replay option and it worked for me. But I am not really the person that can review these changes. |
That's good enough, most of the changes aren't that interesting. The existing px4_sitl_default replay behavior isn't changed, so we don't have to make any difficult decisions here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small follow up on #13749.
There was potential confusion between px4_sitl_default built in replay mode or not. To get around this I introduced a stripped down px4_sitl_replay config. Then the vscode launch is split to be appropriate for either replay or simulation.