Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add NMEA-0183 Protocol GPS Driver #14773

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Add NMEA-0183 Protocol GPS Driver #14773

wants to merge 1 commit into from

Conversation

bys1123
Copy link
Contributor

@bys1123 bys1123 commented Apr 27, 2020

Work in Progress, need some test, bring to timeline first.

Driver source code at: PX4/PX4-GPSDrivers#58

@bys1123 bys1123 changed the title [WIP] Add NMEA GPS Driver [WIP] Add NMEA 0183 GPS Driver Apr 28, 2020
@bys1123 bys1123 changed the title [WIP] Add NMEA 0183 GPS Driver [WIP] Add NMEA-0183 Protocol GPS Driver Apr 28, 2020
@TSC21 TSC21 requested a review from bkueng April 28, 2020 18:43
@weekly-digest weekly-digest bot mentioned this pull request May 3, 2020
Closed
@stale
Copy link

stale bot commented Jul 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Jul 27, 2020
@moreba1
Copy link
Contributor

moreba1 commented Nov 19, 2020

@lukegluke
@bkueng
@dagar
could this PR be merged?

@stale stale bot removed the stale label Nov 19, 2020
@lukegluke
Copy link
Contributor

could this PR be merged?

FMPOV, driver source code (PX4/PX4-GPSDrivers#58) needs corrections I mentioned in comments there. Also it needs style fix same as in ashtech driver recently.
In fact it would be proper to combine somehow ashtech driver and nmea, of course if somebody has time for this.

@petergerten
Copy link

As this seems to be stalled - does this mean currently the PX4 gps driver does not support NMEA-0183?
I am interested in integrating the NoopLoop UWB positioning system which fakes a NMEA GPS.

@bkueng
Copy link
Member

bkueng commented May 26, 2021

@petergerten atm no. Can you test this branch? https://github.com/PX4/PX4-GPSDrivers/tree/generic_nmea_driver

@997430340
Copy link

由于这似乎是停滞不前-这是否意味着目前PX4 GPS驱动并不能支持NMEA-0183？
我对集成伪造 NMEA GPS的NoopLoop UWB 定位系统感兴趣。

Hello, I have just started nooploop. Have you verified whether this NMEA can be used? Is there any way?

@junwoo091400 junwoo091400 added the Drivers 🔧 Sensors, Actuators, etc label Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moreba1 moreba1 moreba1 approved these changes

@bkueng bkueng Awaiting requested review from bkueng

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Drivers 🔧 Sensors, Actuators, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bys1123 @moreba1 @lukegluke @petergerten @bkueng @997430340 @junwoo091400