Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added yaw to CMD_DO_SET_HOME #14810

Merged
merged 1 commit into from
Sep 11, 2021
Merged

Added yaw to CMD_DO_SET_HOME #14810

merged 1 commit into from
Sep 11, 2021

Conversation

dayjaby
Copy link
Contributor

@dayjaby dayjaby commented May 2, 2020

Describe problem solved by this pull request
Before, CMD_DO_SET_HOME had no yaw angle specified, which renders it a bit useless compared to SET_HOME_POSITION. With this PR param4 will be used as the yaw in degrees. A PR to the mavlink documentation will follow.

@dayjaby
Copy link
Contributor Author

dayjaby commented Jul 10, 2020

Can we get this merged? The corresponding PRs in mavlink and mavros are already merged.

@stale
Copy link

stale bot commented Oct 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Oct 12, 2020
@mcsauder
Copy link
Contributor

mcsauder commented Sep 7, 2021

Hi @dayjaby , would you want to rebase this PR and resolve the conflict? Since the mavlink PR's have gone through these changes look good to me. Nice work.

@stale stale bot removed the stale label Sep 7, 2021
@dayjaby dayjaby force-pushed the cmd_do_set_home_yaw branch from 1b43a76 to 2d88c5e Compare September 7, 2021 18:13
@dayjaby
Copy link
Contributor Author

dayjaby commented Sep 7, 2021

@mcsauder Done. Looking forward to test your RTL heading code; especially in tandem with vision-based precision landing.

@dayjaby dayjaby force-pushed the cmd_do_set_home_yaw branch from 2d88c5e to 6dccae5 Compare September 7, 2021 18:24
Copy link
Contributor

@mcsauder mcsauder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @dayjaby !

@dagar dagar merged commit 7d7200c into PX4:master Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants