mission: warn at 2/3 of the max distance #8873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was wrong, instead of warning at 2/3 of the max distance as mentioned in the comment, we would start to warn at 3/2 of the distance which would then never actually happen.
julianoes
referenced
this pull request
Feb 12, 2018
Instead of just checking whether the first waypoint is too far away from home it makes sense to also check between waypoints. This can prevent - flyaways due to user errors, or - catch the corner case where a takeoff waypoint is added to a mission and therefore the first waypoint is not too far away, however, the subsequent waypoints are still too far away.
LorenzMeier
approved these changes
Feb 12, 2018
|
CI failure is an actual firmware bug, but not your doing. |
dagar
approved these changes
Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was wrong, instead of warning at 2/3 of the max distance as
mentioned in the comment, we would start to warn at 3/2 of the distance
which would then never actually happen.
Found by @CornerOfSkyline.