printload: fix buffer overflow on NuttX #8884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NuttX config variable CONFIG_TASK_NAME_SIZE does not include the null terminator byte, thus the buffer needs to be longer by 1 byte.
|
Awesome! |
LorenzMeier
approved these changes
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NuttX config variable
CONFIG_TASK_NAME_SIZEdoes not include thenull terminator byte, thus the buffer needs to be longer by 1 byte.
We have
CONFIG_TASK_NAME_SIZEset to 24 and most of the task names are shorter than that, so we did not notice. Except forlanding_target_estimator, which lead to random bytes being printed when it was running.This then lead to invalid strings in the log file, since the output of printload is logged.
Fixes #8877