Battery: Switch thrust based load compensation back to linear #8929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably also change the comment in line 181 to avoid confusion. |
To account for the parameter definition. My tests if quadratic is actually better in practise were anyways not conclusive.
MaEtUgR
force-pushed
the
pr-battery-thrust-compensation-fix
branch
from
a87d211 to
6081887
Compare
|
@nanthony21 Of course, thanks for pointing it out. |
dagar
approved these changes
Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To account for the parameter definition:
https://github.com/PX4/Firmware/blob/master/src/modules/systemlib/battery_params.c#L129
My tests if quadratic is actually better in practise were anyways not clearly conclusive.
I saw this inconsistency while looking at #8868
FYI @nanthony21