-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete VT_FW_PITCH_TRIM parameter #9014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that useful for tailsitter (and tiltrotors with tilting wings) since the trim is not the same during hover and FW flight?
It's only being added to the actuator_control coming from the FW controller. In master - https://github.com/PX4/Firmware/blob/master/src/modules/vtol_att_control/tailsitter.cpp#L403-L404 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, not useful.
46de604
to
d4b88a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Not sure if the problem in the past was that we did not have the trim implemented for aux.
At the moment I don't see a reason for it to exist.
I've been using this parameter for a tiltwing that hovers at different angle to forward flight (like @bresch said). What's alternative to set FW pitch angle different to MC? Cheers |
@jux2 if you're talking about the FW frame vs MC (not specifically the actuator trim) then take a look at the fixedwing pitch setpoint offset (FW_PSP_OFF). |
We don't need this in addition to regular TRIM.