GPS: explicitly disable flow control #9019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the GPS driver was used on another port (e.g. TELEM2), it would get stuck in a `write` call and not return anymore. Disabling flow control fixes that. CPU usage is unchanged.
LorenzMeier
approved these changes
Mar 5, 2018
|
Anyone have an idea when this fix makes it into a gold version |
|
Has this fix made it into a gold release |
|
@Rickyg32 Please stop spamming. If you need this fix on a stable release version, you will need to cherry-pick it to 1.7.4. You can also directly use master. We do not yet have a hard release timeline for v1.8.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the GPS driver was used on another port (e.g. TELEM2), it would get stuck in a
writecall and not return anymore. Disabling flow control fixes that.CPU usage is unchanged.
Tested on a Pixracer, dual gps now works too:
gps start -d /dev/ttyS2 -e /dev/ttyS3(although for testing I only had one GPS connected at a time).Fixes #8945