Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Increase pwmsim stack again to avoid load_mon warning #9068

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

philipoe
Copy link
Contributor

@philipoe philipoe commented Mar 13, 2018

Issue:

PR #9007 decreased the stack size of the pwmsim module, however, the load_mon app now gives a "pwmsim low on stack warning" when running HIL using the current master branch (pwm sim has 1000->980 bytes stack, and needs ca 736 bytes, the load_mon required stack size margin is 300 bytes). I used px4fmu-v2 with rev. 3 silicon, but that should not matter.

Solutions:

  1. Apply this PR -> Done
  2. Decrease the required stack size margin in load_mon

@dagar @LorenzMeier Your decision.

Copy link
Member

@LorenzMeier LorenzMeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need 300 Bytes margin, so this is good.

@LorenzMeier LorenzMeier merged commit ff66605 into PX4:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants